<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jralls%40ceridwen.fremont.ca.us" title="John Ralls <jralls@ceridwen.fremont.ca.us>"> <span class="fn">John Ralls</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - test-integration example not working out-of-the-box (1 patch attached)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=754631">bug 754631</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #310743 status</td>
<td>none
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - test-integration example not working out-of-the-box (1 patch attached)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=754631#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - test-integration example not working out-of-the-box (1 patch attached)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=754631">bug 754631</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jralls%40ceridwen.fremont.ca.us" title="John Ralls <jralls@ceridwen.fremont.ca.us>"> <span class="fn">John Ralls</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=310743&action=diff" name="attach_310743" title="logs icon change and set it at boot">attachment 310743</a> <a href="attachment.cgi?id=310743&action=edit" title="logs icon change and set it at boot">[details]</a></span> <a href='review?bug=754631&attachment=310743'>[review]</a>
logs icon change and set it at boot
In the first hunk, what's the point of exit(1), and having called exit() why
any code after that?
You're leaking pixbufs. Since every press of the button loads a new pixbuf you
need to gdk_pixbuf_unref() the old one first... which you can't do because you
don't have a pointer to it because you made it local.
BTW, declaring variables in the middle of functions is a C11 feature, and Gtk+
needs to support C98.
Calling a callback function outside of a signal handler is bad form.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>