<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c139">Comment # 139</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen" href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a> from <a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> Owen Taylor</a> <pre>(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=744932#c138">comment #138</a>) > (In reply to Owen Taylor from <a href="show_bug.cgi?id=744932#c132">comment #132</a>) > > Review of <a href="attachment.cgi?id=310996&action=diff" name="attach_310996" title="wayland: Support sending wl_surface.enter/leave to cursor surfaces">attachment 310996</a> <a href="attachment.cgi?id=310996&action=edit" title="wayland: Support sending wl_surface.enter/leave to cursor surfaces">[details]</a> <a href='review?bug=744932&attachment=310996'>[review]</a> [review] [review]: > > > > @@ +993,3 @@ > > + MetaWaylandSurfaceRoleCursor *cursor_role = > > + META_WAYLAND_SURFACE_ROLE_CURSOR (surface->role); > > + MetaCursorSprite *displayed_cursor_sprite; > > > > No change needed, but I wanted to mention that there is no line length limit > > in Mutter source code, and the goal of introducing line breaks is to > > maximize readability. > > FWIW I more or less always use vertical split editor buffers, so long lines > are usually unreadable in my setup. If you are working in a module where the normal line length practices are unreadable with your editor settings, then I think there is utility (perhaps even obligation) to adjust your editor settings for the duration of working on that module :-)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>