<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> <span class="fn">Owen Taylor</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #309854 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932#c143">Comment # 143</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong (ultra tiny/small) cursor size on HiDPI screen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=744932">bug 744932</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=otaylor%40redhat.com" title="Owen Taylor <otaylor@redhat.com>"> <span class="fn">Owen Taylor</span></a>
</span></b>
<pre>Review of <span class="bz_obsolete"><a href="attachment.cgi?id=309854&action=diff" name="attach_309854" title="wayland: Introduce XWayland surface role">attachment 309854</a> <a href="attachment.cgi?id=309854&action=edit" title="wayland: Introduce XWayland surface role">[details]</a></span> <a href='review?bug=744932&attachment=309854'>[review]</a>:
::: src/wayland/meta-wayland-surface.c
@@ +566,3 @@
+ * - Go through the surface actors frame callback list until some time
after
+ * it has been mapped so can avoid wasting buffers when the window is
+ * hidden.
I'd like for us to say say:
/* For Xwayland windows, throttling frames when the window isn't
* actually drawn is less useful, because Xwayland still has to do
* the drawing sent from the application - the throttling would only
* be of sending us damage messages, so we simplify and send frame callbacks
* after the next paint of the screen, whether the window was drawn
* or not.
*
* Currently in *some* cases we also seem to take a few frames before
* we draw the window, for not completely understood reasons, and in
* that case, not thottling frame callbacks to drawing has the
* happy side effect that we avoid showing the user the initial black
* frame from when the window is mapped empty.
*/
I can't find anything the code that intentionally tries to only show Xwayland
windows on the second frame, and when I add printfs, I don't see this behavior
- for me the first commit seems to be drawn with an already shown window.
Reading the code looks like to me that Xwayland windows are shown only based on
X traffic, without regard to wayland.
I suppose there perhaps is some sequence of, depending on the ordering of:
receiving the WL_SURFACE_ID message
receiving the MapRequest/MapNotify message
the commit messages
where things occur as you've noted, but I can't work out what is, and it
definitely doesn't seem intentional or reliable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>