<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Protocol: wl_buffer.release is racy"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75303#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Protocol: wl_buffer.release is racy"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75303">bug 75303</a>
from <span class="vcard"><a class="email" href="mailto:jadahl@gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Ok, yes I see it now.(In reply to Pekka Paalanen from <a href="show_bug.cgi?id=75303#c7">comment #7</a>)
<span class="quote">> (In reply to Jonas Ådahl from <a href="show_bug.cgi?id=75303#c6">comment #6</a>)
> > Why can't we just let wl_buffer.release simply be a notification about the
> > buffer being reusable
>
> Because it has exactly the race explained in the description of this bug.
> This example applies particular to Weston with gl-renderer and a client
> using wl_shm.</span >
Yes, I see it now. Thanks for the more detailed explanation.
(In reply to Pekka Paalanen from <a href="show_bug.cgi?id=75303#c5">comment #5</a>)
<span class="quote">> Client side reference counting, that is, for every committed attach there
> will be a release, seems like the preferred solution to me at the moment.</span >
How do you expect the client to get the new semantics (one release per commit)
or do you mean to change it for everyone?
<span class="quote">>
> I've forgot the details related to the possibility of implementing
> wl_proxy_get_version(), but from what I recall, it should be perfectly
> doable since we already have runtime object version inheritance in
> libwayland-client (don't we?).</span >
I don't think we do. The client needs to track this information itself. The
client just passes the version to the wl_registry.bind request and the server
uses that to adapt what it sends etc. We can't add it to wl_proxy because
sometimes (wl_buffer, wl_sync), the wl_proxy that is created does not inherit
the version of the parent proxy. Digging some, I found one field name "version"
(in wl_interface), but that is just the version that was in the XML file, hard
coded in the generated -protocol.c file.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>