<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Fix GtkTreeView's search window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756780">bug 756780</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #313621 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Fix GtkTreeView's search window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756780#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Fix GtkTreeView's search window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756780">bug 756780</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=313621&action=diff" name="attach_313621" title="GtkTreeView: Rework the search window hack so it also works on Wayland">attachment 313621</a> <a href="attachment.cgi?id=313621&action=edit" title="GtkTreeView: Rework the search window hack so it also works on Wayland">[details]</a></span> <a href='review?bug=756780&attachment=313621'>[review]</a>:
::: gtk/gtktreeview.c
@@ +6035,2 @@
gtk_tree_view_ensure_interactive_directory (tree_view);
The fixup I attached separately should probably be squashed here.
@@ +11168,3 @@
gtk_window_set_modal (GTK_WINDOW (tree_view->priv->search_window), TRUE);
+ gtk_window_set_transient_for (GTK_WINDOW (tree_view->priv->search_window),
+ GTK_WINDOW (toplevel));
Is this related to the key event handling changes ? looks unrelated to me.
@@ +11279,3 @@
+ /* Grab focus without selecting all the text. */
+ _gtk_entry_grab_focus (GTK_ENTRY (tree_view->priv->search_entry), FALSE);
+
We have public GtkEntry api for this now:
gtk_entry_grab_focus_without_selecting().
Might as well use that here, to reduce our reliance on private APIs.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>