<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - wayland: Fix GtkTreeView's search window" href="https://bugzilla.gnome.org/show_bug.cgi?id=756780#c18">Comment # 18</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - wayland: Fix GtkTreeView's search window" href="https://bugzilla.gnome.org/show_bug.cgi?id=756780">bug 756780</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=756780#c8">comment #8</a>) > Needed this fixup on top to avoid critical warnings. Yes, I have it amended into the commit locally, but forgot to upload again after discovering it. (In reply to Matthias Clasen from <a href="show_bug.cgi?id=756780#c16">comment #16</a>) > Review of <a href="attachment.cgi?id=313620&action=diff" name="attach_313620" title="wayland: Map UTILITY hinted windows as subsurfaces">attachment 313620</a> <a href="attachment.cgi?id=313620&action=edit" title="wayland: Map UTILITY hinted windows as subsurfaces">[details]</a> <a href='review?bug=756780&attachment=313620'>[review]</a> [review]: > > did you look if anything else is using this window type, and will be ok with > this change ? Initially I searched the gtk+ tree, and it seemed safe. Now I did a more broad search, and it seems to be assumed to be a regular toplevel window sometimes, and the couple of places I saw this it was a GDK_WINDOW_TOPLEVEL). I think to limit mapping it as a subsurface only if the window type is GDK_WINDOW_POPUP instead. If we want to be extra safe, I assume we can use the private set-subsurface API, but I wonder if any client using an utility window as a popup expects the grab behaviour that comes with a xdg_popup. Would could also change the type hint in GtkTreeView to TOOLTIP, as it is a no-input window. This is what I did initially, but it seemed odd to make it a "tooltip" when it was clearly not one. Is there any expected semantics of an utility type hint? (In reply to Matthias Clasen from <a href="show_bug.cgi?id=756780#c17">comment #17</a>) > Review of <a href="attachment.cgi?id=313621&action=diff" name="attach_313621" title="GtkTreeView: Rework the search window hack so it also works on Wayland">attachment 313621</a> <a href="attachment.cgi?id=313621&action=edit" title="GtkTreeView: Rework the search window hack so it also works on Wayland">[details]</a> <a href='review?bug=756780&attachment=313621'>[review]</a> [review]: > > @@ +11168,3 @@ > gtk_window_set_modal (GTK_WINDOW (tree_view->priv->search_window), TRUE); > + gtk_window_set_transient_for (GTK_WINDOW (tree_view->priv->search_window), > + GTK_WINDOW (toplevel)); > > Is this related to the key event handling changes ? looks unrelated to me. In order to map the window as a subsurface we need to make it transient to the parent. Without this, we'd fail to map.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>