<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - No kinetic scrolling on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756729">bug 756729</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #313786 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - No kinetic scrolling on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756729#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - No kinetic scrolling on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=756729">bug 756729</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=313786&action=diff" name="attach_313786" title="0001-wayland-add-support-for-wl_pointer-axis_frame-discre.patch">attachment 313786</a> <a href="attachment.cgi?id=313786&action=edit" title="0001-wayland-add-support-for-wl_pointer-axis_frame-discre.patch">[details]</a></span> <a href='review?bug=756729&attachment=313786'>[review]</a>:
Looks quite alright to me, setting to "reviewed" mostly because this is on hold
till we get protocol bits merged. Only very minor formatting niggles (which I
know the wayland backend code is plagued of, but...).
::: gdk/wayland/gdkdevice-wayland.c
@@ +1080,2 @@
static void
+flush_scroll_data (GdkWaylandDeviceData *device, GdkWaylandScrollData *scroll)
One argument per line, please :).
@@ +1173,3 @@
+
+static void
+pointer_handle_axis_source(void *data,
Missing space before '(', variable names should also be aligned to the longest
arg.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>