<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - GtkWindow reacts on maximize action even if it is fixed-width" href="https://bugzilla.gnome.org/show_bug.cgi?id=757530#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - GtkWindow reacts on maximize action even if it is fixed-width" href="https://bugzilla.gnome.org/show_bug.cgi?id=757530">bug 757530</a> from <a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> Olivier Fourdan</a> <pre>(In reply to Olivier Fourdan from <a href="show_bug.cgi?id=757530#c10">comment #10</a>) > [...] > Anyhow, I added this patch for the sake of completion, it's not required to > fix this current issue, if we get <a href="attachment.cgi?id=314814&action=diff" name="attach_314814" title="[Patch 2/3] wayland: apply maximized state only when possible">attachment 314814</a> <a href="attachment.cgi?id=314814&action=edit" title="[Patch 2/3] wayland: apply maximized state only when possible">[details]</a> <a href='review?bug=757530&attachment=314814'>[review]</a> [review] and > <a href="attachment.cgi?id=314815&action=diff" name="attach_314815" title="[PATCH 3/3] window: maximize on double click only if allowed">attachment 314815</a> <a href="attachment.cgi?id=314815&action=edit" title="[PATCH 3/3] window: maximize on double click only if allowed">[details]</a> <a href='review?bug=757530&attachment=314815'>[review]</a> [review] into gtk+ this is less likely to happen. > > Of course, if an app calls gtk_window_maximize() on a window which is not > resizable (or not resizable enough) it will still fail on Wayland without > <a href="attachment.cgi?id=314813&action=diff" name="attach_314813" title="[PATCH 1/3] wayland: do not maximize a window if constrained">attachment 314813</a> <a href="attachment.cgi?id=314813&action=edit" title="[PATCH 1/3] wayland: do not maximize a window if constrained">[details]</a> <a href='review?bug=757530&attachment=314813'>[review]</a> [review] but it's a slightly less probable > scenario (and one could argue that the app itself sets its window constrains > so if the app tries to maximize a window while not allowing for it using > constrains, it would be a bug in the app itself). Actually, no, I'm wrong here. If an app calls gtk_window_maximize() it will translate to gdk_wayland_window_maximize() and we shall receive an event configure from the compositor, and we'll get a chance to deny it with <a href="attachment.cgi?id=314814&action=diff" name="attach_314814" title="[Patch 2/3] wayland: apply maximized state only when possible">attachment 314814</a> <a href="attachment.cgi?id=314814&action=edit" title="[Patch 2/3] wayland: apply maximized state only when possible">[details]</a> <a href='review?bug=757530&attachment=314814'>[review]</a> if the constrains do not allow for it. So we can forget about <a href="attachment.cgi?id=314813&action=diff" name="attach_314813" title="[PATCH 1/3] wayland: do not maximize a window if constrained">attachment 314813</a> <a href="attachment.cgi?id=314813&action=edit" title="[PATCH 1/3] wayland: do not maximize a window if constrained">[details]</a> <a href='review?bug=757530&attachment=314813'>[review]</a>, it's not needed.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>