<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Implement DND icon hotspot API"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759168">bug 759168</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #316924 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Implement DND icon hotspot API"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759168#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Implement DND icon hotspot API"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759168">bug 759168</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=316924&action=diff" name="attach_316924" title="wayland: Implement DND icon hotspot API">attachment 316924</a> <a href="attachment.cgi?id=316924&action=edit" title="wayland: Implement DND icon hotspot API">[details]</a></span> <a href='review?bug=759168&attachment=316924'>[review]</a>:
::: gdk/wayland/gdkdnd-wayland.c
@@ +51,3 @@
gdouble y;
+ gint prev_hot_x;
+ gint prev_hot_y;
I don't see the need to store these in the context. They can just be locals in
set_hot_spot
@@ +329,3 @@
+ .width = 1,
+ .height = 1,
+ },
This kind of on-the-fly struct looks a little out of style in the GTK+
codebase. Do we do this elsewhere in the Wayland backend ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>