<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161">bug 759161</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span></b>
<pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=759161#c10">comment #10</a>)
<span class="quote">> Review of <span class=""><a href="attachment.cgi?id=316949&action=diff" name="attach_316949" title="wayland: Update parent of dialogs without transient">attachment 316949</a> <a href="attachment.cgi?id=316949&action=edit" title="wayland: Update parent of dialogs without transient">[details]</a></span> <a href='review?bug=759161&attachment=316949'>[review]</a> [review]:
>
> ::: gdk/wayland/gdkwindow-wayland.c
> @@ +713,3 @@
> static void
> +gdk_wayland_window_sync_parent (GdkWindow *window,
> + GdkWindow *parent)
>
> You add a parent argument here, but all callers pass NULL ?</span >
Nope, not all.
The parent is used in gdk_wayland_window_update_dialogs() precisely when no
transient is set:
+ /* Update the parent relationship only for dialogs without transients */
+ if (!impl->transient_for)
+ gdk_wayland_window_sync_parent (w, window);
<span class="quote">> @@ +1972,3 @@
> impl->transient_for = parent;
>
> + gdk_wayland_window_sync_parent (window, NULL);
>
> Did you mean to pass the parent in here ?</span >
No, not here (although we could), there is no need as impl->transient_for is
set just above.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>