<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161">bug 759161</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #317059 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161">bug 759161</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=317059&action=diff" name="attach_317059" title="[PATCH v2] wayland: Update parent of dialogs without transient">attachment 317059</a> <a href="attachment.cgi?id=317059&action=edit" title="[PATCH v2] wayland: Update parent of dialogs without transient">[details]</a></span> <a href='review?bug=759161&attachment=317059'>[review]</a>:
::: gdk/wayland/gdkwindow-wayland.c
@@ +1024,3 @@
+ if (impl->hint != GDK_WINDOW_TYPE_HINT_DIALOG &&
+ new_state & GDK_WINDOW_STATE_FOCUSED)
+ gdk_wayland_window_update_dialogs (window);
So whenever a non-dialog is focused, we create and iterate a list of all
toplevels. Not sure I like that. Could we instead keep track of whether there
are any orphan dialogs, and only do the work if we have any ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>