<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - dnd drag cancellation animation missing"
href="https://bugzilla.gnome.org/show_bug.cgi?id=735888">bug 735888</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #317072 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - dnd drag cancellation animation missing"
href="https://bugzilla.gnome.org/show_bug.cgi?id=735888#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - dnd drag cancellation animation missing"
href="https://bugzilla.gnome.org/show_bug.cgi?id=735888">bug 735888</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=317072&action=diff" name="attach_317072" title="dnd: Stop doing cancel animation in GTK+">attachment 317072</a> <a href="attachment.cgi?id=317072&action=edit" title="dnd: Stop doing cancel animation in GTK+">[details]</a></span> <a href='review?bug=735888&attachment=317072'>[review]</a>:
::: gtk/gtkdnd.c
@@ +3202,3 @@
+ /* keep the icon_window alive until the (possible) drag cancel animation is
done */
+ g_object_set_data_full (G_OBJECT (info->context), "former-gtk-source-info",
info, (GDestroyNotify)gtk_drag_source_info_free);
Been thinking on this and can't figure out a better way tbh... we can't add a
post-animation vfunc to GdkDragContext because x11 is the only place we can
know that, and hooking the GtkDragSourceInfo to the icon_window widget being
destroyed relies on gdk knowing how to indirectly destroy the widget in the
first place.
That said, the GtkDragSourceInfo is already previously attached to the context
as dest_info_quark, we might as well set up a GDestroyNotify when creating the
source info and making gtk_drag_clear_source_info() steal the qdata.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>