<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161">bug 759161</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #317371 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: dialog stacking without parents (RFC)"
href="https://bugzilla.gnome.org/show_bug.cgi?id=759161">bug 759161</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=mclasen%40redhat.com" title="Matthias Clasen <mclasen@redhat.com>"> <span class="fn">Matthias Clasen</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=317371&action=diff" name="attach_317371" title="[PATCH v3] wayland: Update parent of dialogs without transient">attachment 317371</a> <a href="attachment.cgi?id=317371&action=edit" title="[PATCH v3] wayland: Update parent of dialogs without transient">[details]</a></span> <a href='review?bug=759161&attachment=317371'>[review]</a>:
::: gdk/wayland/gdkscreen-wayland.c
@@ +1275,3 @@
+ GdkWaylandScreen *screen_wayland = GDK_WAYLAND_SCREEN (screen);
+
+ return g_list_copy (screen_wayland->orphan_dialogs);
I would prefer to return the list itself here, without a copy. This is not
public api, and we know the only caller, so seems quite safe. Alternatively
(and maybe preferrably) keep the entire orphan dialog business static in
gdkwindow-wayland.c - there's only one screen object anyway, and we avoid
adding these (internal) apis.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>