<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: gdk_seat_grab() set cursor not resilient"
href="https://bugzilla.gnome.org/show_bug.cgi?id=760213">bug 760213</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #318320 status</td>
<td>reviewed
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #318320 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: gdk_seat_grab() set cursor not resilient"
href="https://bugzilla.gnome.org/show_bug.cgi?id=760213#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: gdk_seat_grab() set cursor not resilient"
href="https://bugzilla.gnome.org/show_bug.cgi?id=760213">bug 760213</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=318485&action=diff" name="attach_318485" title="[PATCH v2] wayland: Update parent of dialogs without transient">attachment 318485</a> <a href="attachment.cgi?id=318485&action=edit" title="[PATCH v2] wayland: Update parent of dialogs without transient">[details]</a></span> <a href='review?bug=760213&attachment=318485'>[review]</a>
[PATCH v2] wayland: Update parent of dialogs without transient
(In reply to Matthias Clasen from <a href="show_bug.cgi?id=760213#c2">comment #2</a>)
<span class="quote">> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=318320&action=diff" name="attach_318320" title="[PATCH] wayland: gdk_seat_grab() set a resilient cursor">attachment 318320</a> <a href="attachment.cgi?id=318320&action=edit" title="[PATCH] wayland: gdk_seat_grab() set a resilient cursor">[details]</a></span> <a href='review?bug=760213&attachment=318320'>[review]</a> [review]:
>
> ::: gdk/wayland/gdkdevice-wayland.c
> @@ +2561,2 @@
> wayland_seat->pointer_grab_window = NULL;
> + _gdk_display_set_window_under_pointer (display,
> wayland_seat->master_pointer, window);
>
> Calling set_window_under_pointer here seems wrong - the window may not be
> under the pointer at all at this point.</span >
Right, what we want is to update toe cursor to whatever is relevant for the
window under the cursor.
<span class="quote">> And as Carlos points out,</span >
Not sure I followed here, where did Carlos pointed that out, was it on irc?
<span class="quote">> this should already be happening in switch_to_pointer_grab.</span >
Thing is, we "block" the cursor change while we have a grab, so we need to
update the cursor again after the grab is released.
Is it better to use gdk_wayland_device_update_window_cursor() for this purpose
instead of _gdk_display_set_window_under_pointer() here? (updated patch)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>