<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - A few clean ups to the shm handling code" href="https://bugzilla.gnome.org/show_bug.cgi?id=760897#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - A few clean ups to the shm handling code" href="https://bugzilla.gnome.org/show_bug.cgi?id=760897">bug 760897</a> from <a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> Ray Strode [halfline]</a> <pre>Created <a href="attachment.cgi?id=319452&action=diff" name="attach_319452" title="wayland: unlink shm file earlier in create function">attachment 319452</a> <a href="attachment.cgi?id=319452&action=edit" title="wayland: unlink shm file earlier in create function">[details]</a> <a href='review?bug=760897&attachment=319452'>[review]</a> wayland: unlink shm file earlier in create function create_shm_pool unlinks the temporary file a little, too late. It should be unlinked before ftruncate() is called for two reasons: 1) if ftruncate fails, the file is currently not getting cleaned up at all 2) in theory, if the file is public some other process could muck with it This commit just moves the unlink call a little higher up.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>