<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - memory leak" href="https://bugzilla.gnome.org/show_bug.cgi?id=761312#c17">Comment # 17</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - memory leak" href="https://bugzilla.gnome.org/show_bug.cgi?id=761312">bug 761312</a> from <a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>Review of <a href="attachment.cgi?id=320152&action=diff" name="attach_320152" title="wayland: release buffer after processing commit">attachment 320152</a> <a href="attachment.cgi?id=320152&action=edit" title="wayland: release buffer after processing commit">[details]</a> <a href='review?bug=761312&attachment=320152'>[review]</a>: ::: src/wayland/meta-wayland-surface.c @@ +610,3 @@ + if (pending->buffer) + meta_wayland_buffer_release_control (pending->buffer); Is this really correct? If the buffer is an EGL buffer, then doesn't our surface actor texture directly map to the buffer allocated by the client? I.e. we cannot release the buffer until it is replaced by a future commit + next frame, if the buffer is a EGL buffer. For SHM buffers than this looks good.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>