<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - memory leak"
href="https://bugzilla.gnome.org/show_bug.cgi?id=761312#c54">Comment # 54</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - memory leak"
href="https://bugzilla.gnome.org/show_bug.cgi?id=761312">bug 761312</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span></b>
<pre>So my first reaction to <a href="show_bug.cgi?id=761312#c53">comment 53</a> was that I thought there shouldn't be a
leak. in step 3 committed = NULL, so the buffer release call back will destroy
the surface and its associated user data which will call the final reference to
the window to disappear. Turns out I never nullified the variable in destroy
though, just update_size. I'll do one more update with that change.
Regarding what the advantage is? It's not about leaks if the server goes away,
i mean if the server goes away we're going down too. It's pretty much 6 of 1
and half a dozen of another to me, and I could happily go either way. The only
reason (and a small one at that) that I decided to go this route was for
accounting reasons to aid in future debugging. In the future, if we're trying
to wrap our heads around a bug and we break with gdb we get access to the
destroyed window impl and can inspect its state to help deduce what's going on.
Doing it this way, also leaves the code in a position where we could track
unreleased buffers separately if we wanted to with some other changes (which
would also help with debugging down the line, but is otherwise unnecessary)
So I went this way because it seemed marginally better at the time, and it
still seems marginally better now. I don't *really* care though. I'm only
reluctant to change it now because I already did it this way and I don't see a
strong reason for changing it to the other way. If you give me a strong reason
to change it, or if this way really bothers you, i'll do another round.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>