[PATCH 1/2] Add to output protocol to allow rotate/resize

[Casey Dahlin]

On Fri, Apr 29, 2011 at 09:43:53AM +0200, Benjamin Franzke wrote:
> 2011/4/29 Casey Dahlin <cdahlin at redhat.com>:
> > Adds some parameters to the output geometry event. Also adds a move method to
> > change those parameters.
> > ---
> >  protocol/wayland.xml |   15 ++++++++++++---
> >  1 files changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> > index 11976fa..187e961 100644
> > --- a/protocol/wayland.xml
> > +++ b/protocol/wayland.xml
> > @@ -446,12 +446,21 @@
> >        published as global during start up, or when a screen is hot
> >        plugged.  -->
> >   <interface name="wl_output" version="1">
> > -    <!-- Notification about the screen size. -->
> > +    <!-- Move or rotate this output's area -->
> > +    <request name="move">
> > +      <arg name="x" type="int"/>
> > +      <arg name="y" type="int"/>
> > +      <arg name="transform_flags" type="uint"/>
> > +    </request>
> 
> I think we need a general debate first, about how to grant permission
> to only specific clients to change output configuration.
> Or even not making it part of the main protocol at all, just being an
> extension or so.
> We might not want every application to have control of these things.
> 

xrandr doesn't seem to have much more authentication than this. Its not much
more dangerous than changing the resolution, which many fairly pedestrian apps
expect to be able to do (i.e. games). Indeed its potentially a good deal less
dangerous than fullscreen mode (though that can be fixed with UI), far less
dangerous than screenshots from a security perspective (and we can't have
clients render certain effects if they can't get a copy of what's behind them
to distort), and even a good deal safer than input grabs.

> > +
> > +    <!-- Notification about the screen size, rotation, and applied
> > +        transformations. -->
> >     <event name="geometry">
> >       <arg name="x" type="int"/>
> >       <arg name="y" type="int"/>
> > -      <arg name="width" type="int"/>
> > -      <arg name="height" type="int"/>
> > +      <arg name="transform_flags" type="uint"/>
> > +      <arg name="width" type="uint"/>
> > +      <arg name="height" type="uint"/>
> >     </event>
> >   </interface>
> 
> Why changing the width and height datatype within this patch?
> That would be another patch. But Kristian denied that somewhen already.
> 

Oh yeah, I did do that didn't I? X( I'll kill it in the revision.

--CJD