[PATCH] shell: fix set_transient
ppaalanen at gmail.com
Thu Dec 8 07:08:48 PST 2011
On Thu, 08 Dec 2011 17:04:47 +0200
Tiago Vignatti <tiago.vignatti at linux.intel.com> wrote:
> On 12/08/2011 04:42 PM, Pekka Paalanen wrote:
> > In the wl_shell_surface migration, I forgot to correct one cast in
> > shell_surface_set_transient(). 'parent_resource' is not a (struct
> > wlsc_surface *) but (struct shell_surface *).
> > This bug corrupts a wlsc_surface::output field, which later (in my
> > experiments) leads to a segmentation fault in surface_frame().
> > Fix the casts.
> > Signed-off-by: Pekka Paalanen<ppaalanen at gmail.com>
> Reviewed-by: Tiago Vignatti <tiago.vignatti at intel.com>
> but I thought you'd implement the explicit cast scheme.. meh.
Sorry, not today :-D
I'll keep it in mind, though, for when I have time for it.
For reference to others: it is for improving type safety in the
compositor side, by putting some real pointer types into struct
wl_*_interface's function arguments.
More information about the wayland-devel