[PATCH] wayland: introduce logging with syslog

Tiago Vignatti tiago.vignatti at linux.intel.com
Mon Jul 25 09:03:51 PDT 2011


On 07/25/2011 06:18 PM, Kristian Høgsberg wrote:
> On Fri, Jul 22, 2011 at 1:01 PM, Tiago Vignatti
> <tiago.vignatti at intel.com>  wrote:
>> Three level of messages are possible, which are sent to syslog: WL_INFO,
>> WL_WARNING and WL_ERROR; the last two are printed also to stderr due
>> sanity. The only interface for the compositor and clients is
>>
>>     void wl_log(int level, const char *f, ...);
>
> syslog or not, we don't wan't logging in the core libraries.  For the
> stray fprintf error cases in the libraries, we should clean that up by
> handling the error better or return the error in the API.  The logging
> should be only in wayland-compositor in the wayland-demos repo.

right, but then we miss the logging on client side. And I guess it's 
okay, but if we want to extend for a debugging functionality then we 
have to re-think and squash it anyway in the protocol implementation. 
I'll come back with this idea later.

About handling errors in the protocol, I think we are not doing bad 
cause most of the output generated is due sanity check from system calls 
(apart from the debug's wl_closure_print).

                  Tiago


More information about the wayland-devel mailing list