[PATCH] configure: Use proper equality tests

Kristian Høgsberg krh at bitplanet.net
Tue Jun 21 08:53:53 PDT 2011


On Sun, Jun 19, 2011 at 10:16 PM, Cyril Brulebois <kibi at debian.org> wrote:
> POSIX says equality is tested through the = operator; == is a bashism.

Ok, thanks.

Kristian

> ---
>  configure.ac |   22 +++++++++++-----------
>  1 files changed, 11 insertions(+), 11 deletions(-)
>
> In case a pointer is needed:
>  http://pubs.opengroup.org/onlinepubs/000095399/utilities/test.html
>
> diff --git a/configure.ac b/configure.ac
> index 6edf41d..280e230 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -32,8 +32,8 @@ AM_CONDITIONAL(HAVE_RSVG_CONVERT, test -n "$RSVG_CONVERT")
>
>  AC_ARG_ENABLE(x11-compositor, [  --enable-x11-compositor],,
>              enable_x11_compositor=yes)
> -AM_CONDITIONAL(ENABLE_X11_COMPOSITOR, test x$enable_x11_compositor == xyes)
> -if test x$enable_x11_compositor == xyes; then
> +AM_CONDITIONAL(ENABLE_X11_COMPOSITOR, test x$enable_x11_compositor = xyes)
> +if test x$enable_x11_compositor = xyes; then
>   PKG_CHECK_MODULES([XCB], xcb)
>   xcb_save_LIBS=$LIBS
>   xcb_save_CFLAGS=$CFLAGS
> @@ -50,8 +50,8 @@ fi
>
>  AC_ARG_ENABLE(drm-compositor, [  --enable-drm-compositor],,
>              enable_drm_compositor=yes)
> -AM_CONDITIONAL(ENABLE_DRM_COMPOSITOR, test x$enable_drm_compositor == xyes)
> -if test x$enable_drm_compositor == xyes; then
> +AM_CONDITIONAL(ENABLE_DRM_COMPOSITOR, test x$enable_drm_compositor = xyes)
> +if test x$enable_drm_compositor = xyes; then
>   AC_DEFINE([BUILD_DRM_COMPOSITOR], [1], [Build the DRM compositor])
>   PKG_CHECK_MODULES(DRM_COMPOSITOR, [libudev >= 136 libdrm >= 2.4.23])
>  fi
> @@ -59,8 +59,8 @@ fi
>
>  AC_ARG_ENABLE(openwfd-compositor, [  --enable-openwfd-compositor],,
>              enable_openwfd_compositor=no)
> -AM_CONDITIONAL(ENABLE_OPENWFD_COMPOSITOR, test x$enable_openwfd_compositor == xyes)
> -if test x$enable_openwfd_compositor == xyes; then
> +AM_CONDITIONAL(ENABLE_OPENWFD_COMPOSITOR, test x$enable_openwfd_compositor = xyes)
> +if test x$enable_openwfd_compositor = xyes; then
>   AC_DEFINE([BUILD_OPENWFD_COMPOSITOR], [1], [Build the OpenWF compositor])
>   PKG_CHECK_MODULES(OPENWFD_COMPOSITOR, [openwfd])
>  fi
> @@ -69,8 +69,8 @@ fi
>  AC_ARG_ENABLE(wayland-compositor, [  --enable-wayland-compositor],,
>              enable_wayland_compositor=yes)
>  AM_CONDITIONAL(ENABLE_WAYLAND_COMPOSITOR,
> -              test x$enable_wayland_compositor == xyes)
> -if test x$enable_wayland_compositor == xyes; then
> +              test x$enable_wayland_compositor = xyes)
> +if test x$enable_wayland_compositor = xyes; then
>   AC_DEFINE([BUILD_WAYLAND_COMPOSITOR], [1],
>            [Build the Wayland (nested) compositor])
>   PKG_CHECK_MODULES(WAYLAND_COMPOSITOR, [wayland-client wayland-egl])
> @@ -78,8 +78,8 @@ fi
>
>
>  AC_ARG_ENABLE(clients, [  --enable-clients],, enable_clients=yes)
> -AM_CONDITIONAL(BUILD_CLIENTS, test x$enable_clients == xyes)
> -if test x$enable_clients == xyes; then
> +AM_CONDITIONAL(BUILD_CLIENTS, test x$enable_clients = xyes)
> +if test x$enable_clients = xyes; then
>   AC_DEFINE([BUILD_CLIENTS], [1], [Build the Wayland clients])
>
>   PKG_CHECK_MODULES(SIMPLE_CLIENT,
> @@ -101,7 +101,7 @@ AM_CONDITIONAL(ENABLE_DESKTOP_SHELL, true)
>  AC_ARG_ENABLE(meego-tablet-shell, [  --enable-meego-tablet-shell],,
>              enable_meego_tablet_shell=yes)
>  AM_CONDITIONAL(ENABLE_MEEGO_TABLET_SHELL,
> -              test x$enable_meego_tablet_shell == xyes)
> +              test x$enable_meego_tablet_shell = xyes)
>
>  if test "x$GCC" = "xyes"; then
>        GCC_CFLAGS="-Wall -g -Wstrict-prototypes -Wmissing-prototypes -fvisibility=hidden"
> --
> 1.7.5.4
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>


More information about the wayland-devel mailing list