[PATCH xserver 2/2] xwayland: fix motion coordinates

Tiago Vignatti tiago.vignatti at linux.intel.com
Wed Aug 1 01:48:23 PDT 2012


On 08/01/2012 05:34 AM, Kristian Høgsberg wrote:
> On Tue, Jul 31, 2012 at 03:46:12PM +0300, Tiago Vignatti wrote:
>> clients were getting one pixel shifted on each axis.
>
> Why is this off-by-one?

I haven't checked why. The valuators conversion performed and their 
values accepted at xf86PostMotionEvent are not easy to understand. So 
I've noticed that the way we're feeding the function was off by one: I 
compared what Wayland sent against what X would be sending back to the 
clients... this is called engineering :-P

Do you think it's relevant to understand the internals of that function now?

Tiago


More information about the wayland-devel mailing list