[PATCH weston] shell: Don't draw shadows for maximized windows.

[Andreas Ericsson]

On 08/08/2012 12:52 PM, Scott Moreau wrote:
>>
>> This is definitely not right. It is not the compositor's job to cut out
>> and not show an arbitrary part of the surface. It is the client's job
>> to not render anything it does not want to show.
>>
>> You also break the protocol by lying to client about the dimensions,
>> and in doing so, you make assumptions that are not based on any
>> specification, just like you mentioned yourself.
>>
>> This must be done in toytoolkit, not here.
>>
>>
>> Sorry,
>> pq
>>
> 
> The problem I'm having is trying to work out how to do snapping for resize
> or move requests on maximized surfaces. The patch that works in toytoolkit
> would require even more dancing in shell to implement snapping. The problem
> is that the shell doesn't know some specifics about the surface such as
> input region and/or theme margin, in this case the shadow margin.

Personally, I've always felt it's really weird when ethereal entities such as
shadows interact with physical entities such as the plastic edge framing the
LCD part of my screen. In any sane faking of the real world that plastic edge
would simply cover the shadow, so it makes perfect sense to ignore it
completely when snapping windows.

-- 
Andreas Ericsson                   andreas.ericsson at op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.