[PATCH 3/3] compositor-drm: add sprite support v6

Jesse Barnes jbarnes at virtuousgeek.org
Tue Feb 14 08:39:18 PST 2012


On Tue, 14 Feb 2012 10:52:11 +0100
Benjamin Franzke <benjaminfranzke at googlemail.com> wrote:
> > +       bo = gbm_bo_create_from_egl_image(c->gbm, c->base.display, es->image,
> > +                                         es->geometry.width, es->geometry.height,
> > +                                         GBM_BO_USE_SCANOUT);
> > +       format = gbm_bo_get_format(bo);
> 
> Havent seen a patch for GBM, that introduces gbm_bo_get_format.
> From how you use format, it looks like you expect it to return a DRM_FORMAT_*?
> Since GBM is in general modesetting-api independent it should return a
> GBM_BO_FORMAT_*.

Right, Kristian suggested the new API and has a patch for it.  It would
be nice if the values were compatible with the DRM versions, otherwise
we'll have to add a conversion function so we get the right numbers.

> The reason for that is, that I want to keep it possible to implement
> OpenWF Display with GBM, without DRM.
> So that we have practical example and API towards the
> Wayland-needs-KMS misinformation.

Yep, understood.  Does OpenWF have the notion of surface formats like
this?

-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120214/33b371e7/attachment.pgp>


More information about the wayland-devel mailing list