[PATCH] protocol: Remove "repeat" from "key_state"

Kristian Høgsberg hoegsberg at gmail.com
Tue Jul 31 19:36:45 PDT 2012


On Tue, Jul 31, 2012 at 06:59:09PM +0200, Andre Heider wrote:
> This is unused and apparently was never implemented.
> ---
> While this might qualify as api breakage, the occurence of the repeat enum
> in public headers might confuse users (read: me). As I understood on irc,
> this will never be implemented, so it can be argued that its even nice to
> point users at non-working code with a compile error.

Yes, I agree.  There's nothing that I know that uses the repeat value,
and if anything did, it would be broken anyway.

thanks,
Kristian

>  protocol/wayland.xml |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 4b500e6..cfe95c0 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -908,11 +908,9 @@
>      <enum name="key_state">
>        <description summary="physical key state">
>          Describes the physical state of a key which provoked the key event.
> -	When a key repeats, the sequence is down -> repeat -> repeat -> up.
>        </description>
>        <entry name="released" value="0" summary="key is not pressed"/>
>        <entry name="pressed" value="1" summary="key is pressed"/>
> -      <entry name="repeat" value="2" summary="key is pressed and repeating"/>
>      </enum>
>  
>      <event name="key">
> -- 
> 1.7.10.4
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list