[PATCH 6/6] Hack up distcheck for publican

Gaetan Nadon gaetan.nadon at videotron.ca
Thu Mar 1 07:32:28 PST 2012


On 12-02-29 07:40 PM, Peter Hutterer wrote:
>> +# Copy the en_US source files into en-US destination
>> > +# This is required for out-of-source-tree build as publican does not allow us
>> > +# to specify the location of the source code.
>> > +$(builddir)/en-US/%: $(srcdir)/en_US/% $(builddir)/en-US/Protocol.xml
>> > +	$(AM_V_GEN)cp -f $< $@
> fwiw, this will break if the source directory is read-only (bz 798484).
I am a bit confused. When srcdir=builddir, that directory better be
writeable, else nothing can be built, publican or otherwise. The
limitation of publican is that it forces the build to occur in the same
directory as the source.

The following target incorrectly attempts to build in the srcdir. Note
that publican is not involved. It is always wrong, but it works when
srcdir=builddir.

    docbook-xsl: $(top_srcdir)/protocol/wayland.xml protocol-to-docbook.xsl
        $(AM_V_GEN)$(XSLTPROC) protocol-to-docbook.xsl
    $(top_srcdir)/protocol/wayland.xml > *$(srcdir)*/en-US/Protocol.xml

Let's bypass this target and assume that we don't need this
Protocol.xml. We would not go very far.

    nadon at memsize:~/xorg/src/wayland/wayland-master/_build/doc/Wayland$
    publican build --lang en-US --format html,pdf --config
    ../../../doc/Wayland/publican.cfg
    Can't locate required file: en-US/Book_Info.xml at /usr/bin/publican
    line 556

Publican cannot build anything because there is no source when
srcdir!=builddir. One would expect an option on publican to tell it
where the source is, but no such luck. This is what builddir looks like:

    nadon at memsize:~/xorg/src/wayland/wayland-master/_build/doc/Wayland$
    ls -l
    total 12
    -rw-rw-r-- 1 nadon nadon 11962 2012-03-01 10:04 Makefile

That's it. No en-US, nothing. I think that the previous error about
Protocol.xml combined with the bug report is misleading. The issue is
not about srcdir being read-only.

You can reproduce the problem without autotools. Simply cd where en-US
is not in sight and try to run publican.





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20120301/c7055f30/attachment.htm>


More information about the wayland-devel mailing list