[PATCH 4/5] Use blocking output for the pipe

Pekka Paalanen ppaalanen at gmail.com
Mon Mar 19 01:57:47 PDT 2012


On Sun, 18 Mar 2012 22:56:21 -0700
spitzak at gmail.com wrote:

> From: Bill Spitzak <spitzak at lulu.(none)>
> 
> It certainly looks like this message must be sent!
> ---
>  src/connection.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/src/connection.c b/src/connection.c
> index 1f707ed..9f78c85 100644
> --- a/src/connection.c
> +++ b/src/connection.c
> @@ -277,8 +277,7 @@ wl_connection_data(struct wl_connection *connection, uint32_t mask)
>  		msg.msg_flags = 0;
>  
>  		do {
> -			len = sendmsg(connection->fd, &msg,
> -				      MSG_NOSIGNAL | MSG_DONTWAIT);
> +			len = sendmsg(connection->fd, &msg, MSG_NOSIGNAL);
>  		} while (len < 0 && errno == EINTR);
>  
>  		if (len == -1 && errno == EPIPE) {

Are you sure this won't reintroduce the following issue?
http://lists.freedesktop.org/archives/wayland-devel/2012-February/002394.html

Btw. Bill, good job with sending git patches. One more thing you could
do, tell git your email address so it goes into the history right[1]:
$ git config --global user.email you at yourdomain.example.com


Thanks,
pq

[1] http://schacon.github.com/git/gittutorial.html


More information about the wayland-devel mailing list