[PATCH weston 7/8] westoy: Schedule a full resize when we add a subsurface

Bill Spitzak spitzak at gmail.com
Wed Nov 13 12:41:33 PST 2013


Is this to force the commit so that the subsurface appears? It might be 
better to have a direct way to get the commit to happen without 
redrawing the main surface.

In any case this looks a lot like you are hiding a bug that perhaps 
should be investigated, especially if it is in weston or your 
compositor, rather than in the toytoolkit.

Jasper St. Pierre wrote:
> If a client adds a subsurface, we need to make sure it's allocated
> properly, so queue a resize and redraw on the parent window.
> ---
>  clients/window.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/clients/window.c b/clients/window.c
> index 5a1c8ec..df56bd9 100644
> --- a/clients/window.c
> +++ b/clients/window.c
> @@ -4462,6 +4462,9 @@ window_add_subsurface(struct window *window, void *data,
>  		assert(!"bad enum subsurface_mode");
>  	}
>  
> +	window->resize_needed = 1;
> +	window_schedule_redraw(window);
> +
>  	return widget;
>  }
>  


More information about the wayland-devel mailing list