[PATCH 10/17] shell: Don’t change popups’ window types until the next configure event

Philip Withnall philip at tecnocode.co.uk
Mon Nov 25 10:01:39 PST 2013


From: Philip Withnall <philip.withnall at collabora.co.uk>

This standardises their behaviour with that of the other window types,
where the type change is only committed on configure.
---
 src/shell.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/shell.c b/src/shell.c
index 3ff395d..c503d4b 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -2189,13 +2189,14 @@ set_popup(struct shell_surface *shsurf,
 {
 	assert(parent != NULL);
 
-	shsurf->type = SHELL_SURFACE_POPUP;
 	shsurf->popup.shseat = get_shell_seat(seat);
 	shsurf->popup.serial = serial;
 	shsurf->popup.x = x;
 	shsurf->popup.y = y;
 
 	shell_surface_set_parent(shsurf, parent);
+
+	shsurf->next_type = SHELL_SURFACE_POPUP;
 }
 
 static void
-- 
1.8.3.1



More information about the wayland-devel mailing list