[PATCH 1/2] doc: Switch from static image files to generated diagrams.

Pekka Paalanen ppaalanen at gmail.com
Fri Dec 19 05:51:02 PST 2014


On Fri, 12 Dec 2014 14:19:11 -0800
"Jon A. Cruz" <jonc at osg.samsung.com> wrote:

> Switches diagrams from using static PNG images to instead generate them via
> simple graphviz DOT markup files.
> 
> Signed-off-by: Jon A. Cruz <jonc at osg.samsung.com>
> ---
>  configure.ac                                       |  13 +++++
>  doc/doxygen/Makefile.am                            |  15 ++++--
>  doc/doxygen/dot/wayland-architecture.gv            |  39 +++++++++++++++
>  doc/doxygen/dot/x-architecture.gv                  |  54 +++++++++++++++++++++
>  doc/publican/Makefile.am                           |  29 ++++++-----
>  .../sources/images/wayland-architecture.png        | Bin 29162 -> 0 bytes
>  doc/publican/sources/images/x-architecture.png     | Bin 37306 -> 0 bytes
>  7 files changed, 136 insertions(+), 14 deletions(-)
>  create mode 100644 doc/doxygen/dot/wayland-architecture.gv
>  create mode 100644 doc/doxygen/dot/x-architecture.gv
>  delete mode 100644 doc/publican/sources/images/wayland-architecture.png
>  delete mode 100644 doc/publican/sources/images/x-architecture.png

Hi,

this patch doesn't build for me. I tried applying it on top of
163ce87cd732702328f76d20f24099041bb119ec, because it conflicts in
master. The error is:

make[3]: Entering directory '/home/pq/git/wayland/doc/doxygen'
  GEN      xml
  GEN      xml/wayland-architecture.png
Error: dot/wayland-architecture.gv:3: syntax error near line 3
context:         fontname="DejaVu >>>  Sans"; <<< 
Makefile:572: recipe for target 'xml/wayland-architecture.png' failed
make[3]: *** [xml/wayland-architecture.png] Error 1
make[3]: Leaving directory '/home/pq/git/wayland/doc/doxygen'

$ dot -V
dot - graphviz version 2.26.3 (20100126.1600)

---
Anyway, is everyone ok with the idea of thise patches?


Thanks,
pq


More information about the wayland-devel mailing list