[PATCH libinput 5/8] evdev: Early out during configure if not using fallback dispatch

Peter Hutterer peter.hutterer at who-t.net
Wed Jul 16 21:25:18 PDT 2014


On Wed, Jul 16, 2014 at 10:39:10PM +0200, Jonas Ådahl wrote:
> The feature set configured otherwise would not work anyway as it
> would need using the fallback dispatch to function.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---
>  src/evdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/evdev.c b/src/evdev.c
> index f980812..fec24f5 100644
> --- a/src/evdev.c
> +++ b/src/evdev.c
> @@ -700,9 +700,11 @@ evdev_configure_device(struct evdev_device *device)
>  		    !libevdev_has_event_code(evdev, EV_KEY, BTN_TOOL_PEN) &&
>  		    (has_abs || has_mt)) {
>  			device->dispatch = evdev_mt_touchpad_create(device);
> +			device->seat_caps |= EVDEV_DEVICE_POINTER;
>  			log_info(libinput,
>  				 "input device '%s', %s is a touchpad\n",
>  				 device->devname, device->devnode);
> +			return device->dispatch == NULL ? -1 : 0;

for something that is a touchpad with extra keys you're losing the keyboard
seat_cap here. same for touch, which iirc you can get for wireless receivers
where you may have more than one device multiplexed. which the touchpad code
probably won't handle yet anyway, but still.

Cheers,
   Peter

>  		}
>  		for (i = KEY_ESC; i < KEY_MAX; i++) {
>  			if (i >= BTN_MISC && i < KEY_OK)
> -- 
> 1.8.5.1
 


More information about the wayland-devel mailing list