[PATCH weston] exposay: fix crash when navigating with the keyboard

Kristian Høgsberg hoegsberg at gmail.com
Wed Jun 18 16:11:25 PDT 2014


On Sat, May 24, 2014 at 02:43:04AM +0200, Emilio Pozuelo Monfort wrote:
> From: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
> 
> Commit a7592019 introduced an optimization that caused some
> exposay struct members to not be properly initialized, particularly
> cur_output, leading to crashes in some circumstances (e.g. pressing
> the down arrow key after going to exposay).
> 
> Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>

Thanks, I see the problem, and this fixes it.  Committed.

Kristian

> ---
>  desktop-shell/exposay.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/desktop-shell/exposay.c b/desktop-shell/exposay.c
> index 1d8b40e..104b9d9 100644
> --- a/desktop-shell/exposay.c
> +++ b/desktop-shell/exposay.c
> @@ -323,8 +323,10 @@ exposay_layout(struct desktop_shell *shell, struct shell_output *shell_output)
>  		i++;
>  	}
>  
> -	if (highlight)
> +	if (highlight) {
> +		shell->exposay.focus_current = NULL;
>  		exposay_highlight_surface(shell, highlight);
> +	}
>  
>  	weston_compositor_schedule_repaint(shell->compositor);
>  
> -- 
> 2.0.0.rc2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list