[PATCH weston v2] shell: fix segfault in fullscreen binding

Pekka Paalanen ppaalanen at gmail.com
Thu Jun 26 02:47:40 PDT 2014


On Thu, 26 Jun 2014 10:19:32 +0800
Boyan Ding <stu_dby at 126.com> wrote:

> Commit 9aa8ce69 forgot to set shsurf->fullscreen_output in
> fullscreen_binding(), causing segfault when fullscreening using key
> bindings. This patch fixes that.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=79828
> Signed-off-by: Boyan Ding <stu_dby at 126.com>
> ---
>  desktop-shell/shell.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
> index d267cde..f22cef8 100644
> --- a/desktop-shell/shell.c
> +++ b/desktop-shell/shell.c
> @@ -4193,6 +4193,7 @@ fullscreen_binding(struct weston_seat *seat, uint32_t time, uint32_t button, voi
>  
>  	shsurf->state_requested = true;
>  	shsurf->requested_state.fullscreen = !shsurf->state.fullscreen;
> +	shsurf->fullscreen_output = shsurf->output;
>  	send_configure_for_surface(shsurf);
>  }
>  

Jason pushed this, thanks,
pq


More information about the wayland-devel mailing list