[PATCH 1/3] wayland: Add wl_output name event

[Wang, Quanxian]

>-----Original Message-----
>From: Bryce W. Harrington [mailto:b.harrington at samsung.com]
>Sent: Wednesday, March 19, 2014 3:09 AM
>To: Wang, Quanxian
>Cc: wayland-devel at lists.freedesktop.org; jason at jlekstrand.net
>Subject: Re: [PATCH 1/3] wayland: Add wl_output name event
>
>On Mon, Mar 17, 2014 at 11:34:50AM +0800, Quanxian Wang wrote:
>> This event contains name of output. It may be sent after binding the
>> output object. It is intended that client could input a character
>> output name as a parameter or for log output.
>>
>> Signed-off-by: Quanxian Wang <quanxian.wang at intel.com>
>> ---
>>  protocol/wayland.xml | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/protocol/wayland.xml b/protocol/wayland.xml index
>> d47ee62..0332e1a 100644
>> --- a/protocol/wayland.xml
>> +++ b/protocol/wayland.xml
>> @@ -1756,6 +1756,17 @@
>>        </description>
>>        <arg name="factor" type="int" summary="scaling factor of output"/>
>>      </event>
>> +
>> +    <event name="name" since="3">
>> +      <description summary="output name properties">
>> +	This event contains name of output. It may be sent after
>> +	binding the output object. It will provide useful name
>> +	for client when they generate the log for user.
>> +	Also it is intended that client could input a character
>> +	output name as a parameter or log.
>
>Fixing up the grammar a bit:
>
>"""
>This event contains the name of the output.  It may be sent after binding the
>output object.  It will provide a useful name for the client when it generates the
>log for the user.  Also, it is intended that the client could input a character output
>name as a parameter or log.
>"""
>
>If I understand the purpose of this patchset properly, this might be clearer
>phrasing:
>
>"""
>This event allows assigning a human-readable alias to an output; it may be sent
>after binding the output object.  It is intended that the client can use this output
>name as a parameter or display it in logs.
>"""
>
[Wang, Quanxian] Thanks Bryce.
>I glanced at the other patches and they look technically correct, but I think what
>might be missing here is a stronger justification about why this is needed?
[Wang, Quanxian] name is one property of output which is assigned detected by backend. In compositor, it is visible. Why is it assigned as a name in compositor? I think display it in compositor logs will be one of reason. Therefore the same thing in client.  At the same time, it provides a good communication with compositor as a choice. Client could take it as a parameter to communicate with compositor, instead of only by wl_output object. I like your word 'human-readable' especially for client. Give client a choice to communicate with compositor without wl_output object, and also give client a choice to display human-readable name in log which is visible to customer. Currently I am designing weston randr protocol, customer(admin or developer) could input a char name to stand for an output from command line. It is just one usage. Anyway, name of output should be visible for both of compositor and client. 
>
>> +      </description>
>> +      <arg name="name" type="string" summary="name of output"/>
>> +    </event>
>>    </interface>
>>
>>    <interface name="wl_region" version="1">
>> --
>> 1.8.1.2
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel