[PATCH] build: honor results obtained by pkg-config libinput

[sardemff7+wayland at sardemff7.net]

On 2014-09-08 15:03, Jan Engelhardt wrote:
> The error was:
> src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory
> ---
>   Makefile.am | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index b2d6893..7f3e5d3 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -34,7 +34,8 @@ AM_CPPFLAGS = 					\
>   	-DDATADIR='"$(datadir)"'		\
>   	-DMODULEDIR='"$(moduledir)"'		\
>   	-DLIBEXECDIR='"$(libexecdir)"'		\
> -	-DBINDIR='"$(bindir)"'
> +	-DBINDIR='"$(bindir)"' \
> +	$(LIBINPUT_BACKEND_CFLAGS)
>
>   CLEANFILES = weston.ini $(BUILT_SOURCES)
>
>

Hi,

You must not put pkg-config *_CFLAGS in *_CPPFLAGS variables, as it can 
contains flags that cpp will not understand. This is especially 
forbidden for AM_CPPFLAGS, which is a global variable used everywhere.

In the same way, you should not put flags in AM_* vars unless they are 
used through your whole project, which I think is not the case here.
Instead, find the targets using src/libinput-seat.c and add 
LIBINPUT_BACKEND_CFLAGS to their _CFLAGS variable.
Hint: add an INPUT_BACKEND_CFLAGS variable mimicking INPUT_BACKEND_LIBS.

Nacked-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Cheers,

-- 

Quentin “Sardem FF7” Glidic