PATCH] Fix new_id(n) arg parse from va list

Jason Ekstrand jason at jlekstrand.net
Tue Sep 30 09:55:46 PDT 2014


While that looks correct, I'm sure it breaks something.  As the person who
wrote that code, that choice was very intentional.  Even though the
protocol type is uint32_t, new_id arguments are always passed into
libwayland as either a wl_proxy or wl_resource and that's what this code is
designed to handle.
--Jason

On Tue, Sep 30, 2014 at 8:45 AM, Jasper St. Pierre <jstpierre at mecheye.net>
wrote:

> What is this trying to solve?
>
> On Mon, Aug 18, 2014 at 11:12 AM, Maks Naumov <maksqwe1 at ukr.net> wrote:
>
>> Signed-off-by: Maks Naumov <maksqwe1 at ukr.net>
>> ---
>>  src/connection.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/connection.c b/src/connection.c
>> index f292853..13e3a3e 100644
>> --- a/src/connection.c
>> +++ b/src/connection.c
>> @@ -492,7 +492,7 @@ wl_argument_from_va_list(const char *signature, union
>> wl_argument *args,
>>                         args[i].o = va_arg(ap, struct wl_object *);
>>                         break;
>>                 case 'n':
>> -                       args[i].o = va_arg(ap, struct wl_object *);
>> +                       args[i].n = va_arg(ap, uint32_t);
>>                         break;
>>                 case 'a':
>>                         args[i].a = va_arg(ap, struct wl_array *);
>> --
>> 1.9.1
>>
>>
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>>
>
>
>
> --
>   Jasper
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140930/53a6d2a7/attachment-0001.html>


More information about the wayland-devel mailing list