[PATCH libinput] evdev: fix inverted mouse normalization

Hans de Goede hdegoede at redhat.com
Wed Apr 8 02:45:41 PDT 2015


p.s.

I've not pushed the patch attached to:

https://bugs.freedesktop.org/show_bug.cgi?id=89949

As I assume you want to wait for feedback from the bug reporter,
but it looks good to me, so feel free to push it.




On 08-04-15 08:05, Peter Hutterer wrote:
> Regression introduced in 9f8edc5fd880e0a9c482b36e6b4120ccc056ee0b where it
> changed from delta / (dpi/default) to delta * dpi/default, causing the inverse
> effect of what the dpi setting is supposed to achieve.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>   src/evdev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/evdev.c b/src/evdev.c
> index 00450bf..243cd22 100644
> --- a/src/evdev.c
> +++ b/src/evdev.c
> @@ -230,8 +230,8 @@ normalize_delta(struct evdev_device *device,
>   		const struct device_coords *delta,
>   		struct normalized_coords *normalized)
>   {
> -	normalized->x = delta->x * (double)device->dpi / DEFAULT_MOUSE_DPI;
> -	normalized->y = delta->y * (double)device->dpi / DEFAULT_MOUSE_DPI;
> +	normalized->x = delta->x * DEFAULT_MOUSE_DPI / (double)device->dpi;
> +	normalized->y = delta->y * DEFAULT_MOUSE_DPI / (double)device->dpi;
>   }
>
>   static void
>


More information about the wayland-devel mailing list