[PATCH wayland] introduce new headers wayland-client/server-core.h

[Giulio Camuffo]

2015-04-30 20:41 GMT+03:00 Bill Spitzak <spitzak at gmail.com>:
> On 04/30/2015 03:34 AM, Pekka Paalanen wrote:
>
>>> Just to be clear, my proposal is:
>>>
>>>     wayland-client.h : hand-written, includes:
>>>         wayland-client-core.h
>>>         wayland-client-protocol.h
>>>         deprecated api
>>>
>>>     wayland-client-core.h : hand-written, includes
>>>         wl_event_queue, wl_proxy, etc
>>>
>>>     *-protocol.h : generated, includes
>>>         inline wrappers for messages and events
>>>         wayland-client-core.h
>>
>>
>> Once again, after discussion, you ended up proposing exactly what the
>> original poster's original patches did.
>
>
> Yes I think you are right, this is the *original* proposal. It is however
> not what is in the current patches.

Functionally the initial patch and the latest ones are exactly the
same, so not sure what you're talking about....

>
> I am trying to remove the circular dependency in the current headers and in
> the "!include_core_only" default case for wayland-scanner. It would also be
> nice to not force programs using a protocol to include a now-deprecated
> header!

What circular dependency? And who forces anybody? They can use
--include-core-only and never ever include wayland-client.h.

>
> Therefore I believe the original poster's version is the correct solution.
>
> If you really want to be anal about back-compatibility it could be solved
> this way, with not
>
> If back compatibility is really a concern, a better fix would be this:
>
>   wayland-client.h : deprecated, hand-written
>     wayland-client-core.h
>     wayland-protocol-client.h
>     deprecated api
>
>   wayland-client-core.h : hand-written, matches existing proposal
>
>   *-protocol-client.h : generated by wayland-scanner
>     wayland-client-core.h
>     wrappers for messages/events/proxy
>
>   *-client-protocol.h : very short file generated by wayland-scanner
>     comment that this file is deprecated
>     *-protocol-client.h
>     wayland-client.h
>
> IMHO back-compatibility is NOT a problem. I posted a patch for weston and it
> was 2 lines.

So what you are suggesting basically is on top of the current patches
to have the wayland build generate also protocol headers with
--include-core-only and to install them. I am not sure i see the
benefit of this, since whoever includes the pre-generated protocol
headers is evidently including them, and the sole reason of this
patchset was to be able to *not* include them.