[PATCH] compositor: Remove unused weston_surface_to_buffer function

Pekka Paalanen ppaalanen at gmail.com
Tue Dec 1 01:30:45 PST 2015


On Mon, 30 Nov 2015 10:23:04 -0500
Chris Michael <cp.michael at samsung.com> wrote:

> The function 'weston_surface_to_buffer' is unused by compositor and
> clients inside weston, so it should be safe to remove this function
> 
> Signed-off-by: Chris Michael <cp.michael at samsung.com>
> ---
>  src/compositor.c | 13 -------------
>  src/compositor.h |  3 ---
>  2 files changed, 16 deletions(-)
> 
> diff --git a/src/compositor.c b/src/compositor.c
> index 4895bd6..e66a8a2 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -919,19 +919,6 @@ weston_surface_to_buffer_float(struct weston_surface *surface,
>  				 *bx, *by, bx, by);
>  }
>  
> -WL_EXPORT void
> -weston_surface_to_buffer(struct weston_surface *surface,
> -			 int sx, int sy, int *bx, int *by)
> -{
> -	float bxf, byf;
> -
> -	weston_surface_to_buffer_float(surface,
> -				       sx, sy, &bxf, &byf);
> -
> -	*bx = floorf(bxf);
> -	*by = floorf(byf);
> -}
> -
>  WL_EXPORT pixman_box32_t
>  weston_surface_to_buffer_rect(struct weston_surface *surface,
>  			      pixman_box32_t rect)
> diff --git a/src/compositor.h b/src/compositor.h
> index 0719abd..1d04481 100644
> --- a/src/compositor.h
> +++ b/src/compositor.h
> @@ -1101,9 +1101,6 @@ weston_view_from_global_fixed(struct weston_view *view,
>  void
>  weston_surface_to_buffer_float(struct weston_surface *surface,
>  			       float x, float y, float *bx, float *by);
> -void
> -weston_surface_to_buffer(struct weston_surface *surface,
> -			 int sx, int sy, int *bx, int *by);
>  pixman_box32_t
>  weston_surface_to_buffer_rect(struct weston_surface *surface,
>  			      pixman_box32_t rect);

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151201/44677f55/attachment.sig>


More information about the wayland-devel mailing list