[PATCH] install pkg-config file to /usr/share

Bryce Harrington bryce at osg.samsung.com
Wed Dec 2 18:13:41 PST 2015


Hi Quentin,

Wayland has some Ubuntu PPA nightly builds set up, which I'm updating to
include wayland-protocols, which weston now needs to build.  However,
one of the targets for these PPAs is the Ubuntu LTS 14.04, which shipped
with an older pkg-config (version 0.26) that lacks support for
PKG_NOARCH_INSTALLDIR (or, at least, it fails build with a message about
noarch_pkgconfigdir being undefined.)

I'm not sure what to do here; Derek suggested asking your advice.  Now,
I could just toss a newer pkg-config package into the PPA to use with
14.04; this would be an easy solution but is just a crutch and wouldn't
help anyone else that might want to build on Ubuntu 14.04.  Another
solution might be to modify wayland-protocols to not require this
feature, at least not when older pkg-config is present; but I'm not sure
whether such a patch would be accepted or how it should be written.
Third option would be to just not worry about supporting packages for
the 14.04 LTS anymore... but the 16.04 LTS is still months off.

Bryce

On Sun, Nov 22, 2015 at 07:48:38PM +0100, Quentin Glidic wrote:
> On 22/11/2015 13:31, Igor Gnatenko wrote:
> >It is arch-independent, so no need to install it to /usr/lib*
> >
> >Signed-off-by: Igor Gnatenko <i.gnatenko.brain at gmail.com>
> >---
> >  Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/Makefile.am b/Makefile.am
> >index a32e977..71b8799 100644
> >--- a/Makefile.am
> >+++ b/Makefile.am
> >@@ -15,5 +15,5 @@ dist_noinst_DATA =								\
> >  	$(sort $(foreach p,$(unstable_protocols),$(dir $p)README))		\
> >  	$(NULL)
> >
> >-pkgconfigdir = $(libdir)/pkgconfig
> >+pkgconfigdir = $(datadir)/pkgconfig
> >  pkgconfig_DATA = wayland-protocols.pc
> >
> 
> 
> Ideally, we should use PKG_NOARCH_INSTALLDIR (in configure.ac) and
> drop the *dir from Makefile.am.
> 
> If that is not wanted, this patch is fine:
> Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> 
> (Sorry for the duplicate mail Igor.)
> 
> -- 
> 
> Quentin “Sardem FF7” Glidic
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list