[PATCH weston] tests: Skip buffer count test if wayland EGL extension isn't present

Daniel Stone daniel at fooishbar.org
Thu Jan 22 13:48:53 PST 2015


Hi,

On Tuesday, January 20, 2015, Derek Foreman <derekf at osg.samsung.com> wrote:

> This also skips the test when running on the headless backend.


I like this part!


> +       if (strstr(extensions, "EGL_WL_bind_wayland_display") == NULL)
> +               skip("Wayland extensions not present.\n");
>

But not this part. bind_wayland_display is the server-side extension, not
the client.

I'd rather skip on:
  - EGL_KHR_platform_base present but not platform_wayland (see Jonny's
patch series)
  - failure to connect to Wayland display
  - failure to create context or surface

That should eliminate basically all the false positives. Thanks for
tackling this niggle though.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150122/0143209a/attachment.html>


More information about the wayland-devel mailing list