[PATCH weston 1/2] text backend should handle existing seats on init.

Murray Calavera murray.calavera at gmail.com
Wed Jun 10 13:29:42 PDT 2015


​Hello,

New patches are here:
http://patchwork.freedesktop.org/patch/51584
http://patchwork.freedesktop.org/patch/51585​


>​ What was the crash exactly?

The crash​ happens because the seat is assigned an input method as soon
as the text backend is initialized.

So If you try to call text_input_activate() before
text_backend_seat_created(),
it will try to get an input_method that doesent exist from the seat.

In theory this should never happen now because without a seat,
text_input_activate
should never be called. And if there is a seat it will have an input_method
if
the global is advertised(thanks to this patch).

Is it better to check if seat->input_method is null just in case?

to reproduce the crash you can just apply the second patch without the
first and use weston-editor to activate the input method.

Thanks
Murray.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150610/20f5add0/attachment.html>


More information about the wayland-devel mailing list