[PATCH 1/2] xdg-shell: Further clarify xdg_surface.move semantics

[Pekka Paalanen]

On Tue,  5 May 2015 15:35:18 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---
> 
> Except for typos etc, this (and the following) patch, compared to the
> previous versions, changes the wording regarding the visual indications
> when moving and resizing.
> 
> 
> Jonas
> 
>  protocol/xdg-shell.xml | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index 7257036..fbd0093 100644
> --- a/protocol/xdg-shell.xml
> +++ b/protocol/xdg-shell.xml
> @@ -248,10 +248,19 @@
>  	Start an interactive, user-driven move of the surface.
>  
>  	This request must be used in response to some sort of user action
> -	like a button press, key press, or touch down event.
> +	like a button press, key press, or touch down event. The passed
> +	serial is used to determine what type of interactive move (touch,
> +	pointer, etc).

Strange sentence. s/what/the/?

>  
>  	The server may ignore move requests depending on the state of
> -	the surface (e.g. fullscreen or maximized).
> +	the surface (e.g. fullscreen or maximized), or if the passed serial
> +	is no longer valid.
> +
> +	If triggered, the surface will lose the focus of the device
> +	(wl_pointer, wl_touch, etc) used for the move. It is up to the
> +	compositor visually indicate that the move is taking place, such as

to visually indicate

> +	updating a pointer cursor, during the move. There is no guarantee
> +	that the device focus will return when the move is completed.
>        </description>
>        <arg name="seat" type="object" interface="wl_seat" summary="the wl_seat of the user event"/>
>        <arg name="serial" type="uint" summary="the serial of the user event"/>

Looks good to me anyway, so feel free to just push a good version of
this patch.


Thanks,
pq