[PATCH wayland 0/5] Allow building just the scanner

Pekka Paalanen ppaalanen at gmail.com
Thu Jun 18 04:07:36 PDT 2015


On Wed, 17 Jun 2015 15:13:47 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:

> Some generic clean ups of the build with the goal being building
> the scanner without any libs or doc.
> 
> This is useful because when cross compiling wayland you only
> need the scanner built natively. It also lets us remove some
> dependencies for the build host (libffi, signalfd, timerfd,
> CLOCK_MONOTONIC).
> 
> We actually have some build boxes that don't support some of this...
> 
> Derek Foreman (5):
>   build: Move AM_CFLAGS and AM_CPPFLAGS to the top of Makefile.am
>   build: Stop putting FFI_CFLAGS in AM_CFLAGS
>   build: Allow disabling building of wayland libraries
>   build: Build a subset of libwayland_util when not building libraries
>   build: Don't depend on libffi unless we're building libraries
> 
>  Makefile.am  | 63 +++++++++++++++++++++++++++++++++---------------------------
>  configure.ac | 32 +++++++++++++++++++-----------
>  2 files changed, 56 insertions(+), 39 deletions(-)
> 

Hi,

I agree with Quentin's and Peter's comments, but I think addressing
those can be follow-ups. This looks good enough to me.

Can we have comments at 'endif's saying which 'if' it matches? Those
would be nice.

R-b me too.

Pushed:
   1faeb7f..bc3b66d  master -> master


Thanks,
pq


More information about the wayland-devel mailing list