[PATCH 14/14] tests: test set for ivi-shell notification with bad condition in server side

Jon A. Cruz jonc at osg.samsung.com
Wed Jun 24 10:04:52 PDT 2015


On 06/21/2015 11:37 PM, Nobuhiko Tanibata wrote:
> From: Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp>
> 
> These tests are implemented on test suite framework, which provides
> internal method validation,
> Following features are tested,
> - add notification of ivi-layer with bad parameter
> - add notification of ivi-surface configure with bad parameter
> - add notification of creating ivi-layer with bad parameter
> - add notification of creating ivi-surface with bad parameter
> - add notification of removing ivi-layer with bad parameter
> - add notification of removing ivi-surface with bad parameter
> 
> Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp>
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Looks good.

Reviewed-by: Jon A. Cruz <jonc at osg.samsung.com>

> ---
>  tests/ivi_layout-internal-test.c | 69 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/tests/ivi_layout-internal-test.c b/tests/ivi_layout-internal-test.c
> index d13c915..bb9cce9 100644
> --- a/tests/ivi_layout-internal-test.c
> +++ b/tests/ivi_layout-internal-test.c
> @@ -1047,6 +1047,69 @@ test_layer_remove_notification(struct test_context *ctx)
>  #undef LAYER_NUM
>  }
>  
> +static void
> +test_layer_bad_properties_changed_notification_callback(struct ivi_layout_layer *ivilayer,
> +							const struct ivi_layout_layer_properties *prop,
> +							enum ivi_layout_notification_mask mask,
> +							void *userdata)
> +{
> +}
> +
> +static void
> +test_layer_bad_properties_changed_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +	struct ivi_layout_layer *ivilayer;
> +
> +	ivilayer = ctl->layer_create_with_dimension(IVI_TEST_LAYER_ID(0), 200, 300);
> +
> +	iassert(ctl->layer_add_notification(
> +		    NULL, test_layer_bad_properties_changed_notification_callback, NULL) == IVI_FAILED);
> +	iassert(ctl->layer_add_notification(ivilayer, NULL, NULL) == IVI_FAILED);
> +
> +	ctl->layer_destroy(ivilayer);
> +}
> +
> +static void
> +test_surface_bad_configure_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +
> +	iassert(ctl->add_notification_configure_surface(NULL, NULL) == IVI_FAILED);
> +}
> +
> +static void
> +test_layer_bad_create_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +
> +	iassert(ctl->add_notification_create_layer(NULL, NULL) == IVI_FAILED);
> +}
> +
> +static void
> +test_surface_bad_create_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +
> +	iassert(ctl->add_notification_create_surface(NULL, NULL) == IVI_FAILED);
> +}
> +
> +static void
> +test_layer_bad_remove_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +
> +	iassert(ctl->add_notification_remove_layer(NULL, NULL) == IVI_FAILED);
> +}
> +
> +static void
> +test_surface_bad_remove_notification(struct test_context *ctx)
> +{
> +	const struct ivi_controller_interface *ctl = ctx->controller_interface;
> +
> +	iassert(ctl->add_notification_remove_surface(NULL, NULL) == IVI_FAILED);
> +}
> +
>  /************************ tests end ********************************/
>  
>  static void
> @@ -1099,6 +1162,12 @@ run_internal_tests(void *data)
>  	test_layer_properties_changed_notification(ctx);
>  	test_layer_create_notification(ctx);
>  	test_layer_remove_notification(ctx);
> +	test_layer_bad_properties_changed_notification(ctx);
> +	test_surface_bad_configure_notification(ctx);
> +	test_layer_bad_create_notification(ctx);
> +	test_surface_bad_create_notification(ctx);
> +	test_layer_bad_remove_notification(ctx);
> +	test_surface_bad_remove_notification(ctx);
>  
>  	weston_compositor_exit_with_code(ctx->compositor, EXIT_SUCCESS);
>  	free(ctx);
> 

-- 
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
jonc at osg.samsung.com


More information about the wayland-devel mailing list