[PATCH weston 4/4] clients & tests: use eglCreatePlatformWindowSurfaceEXT when supported

[Bryce Harrington]

On Thu, Mar 19, 2015 at 02:34:06PM +0100, Jonny Lamb wrote:
> Il 16/03/2015 21:44, Bryce Harrington ha scritto:
> >Since this pattern of code is repeating several places, perhaps having
> >it in a helper function or macro might be more maintainable longer term?
> 
> OK I've done that in my next patch set revision but only in clients
> & tests. I decided not to use the new functions in gl-renderer.c for
> two reasons:
> 
> 1. doing so removes the ability to give a warning of having fallen
>    back to eglGetDisplay (and I don't think the warning should be in
>    the helper function),
> 
> 2. eglCreateWindowSurface and eglCreatePlatformWindowSurface annoyingly
>    take slightly different arguments in the X11 case (see
>    compositor-x11.c) so another argument was added to
>    gl_renderer_interface.output_create which we'd lose the ability to
>    use by using the new functions.

Yep, looking at the patches that's a better choice.  I like how this has
all turned out.  I have one really minor cosmetic suggestion for the 4th
patch but this looks fine to land even without that change.

So for the whole set of four:

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>


Bryce