[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

[Daniel Stone]

On Thursday, March 19, 2015, Bill Spitzak <spitzak at gmail.com> wrote:

> On 03/19/2015 07:07 AM, Jonny Lamb wrote:
>
>> -       if (gl_renderer->output_create(&output->base, output->surface,
>> +       if (gl_renderer->output_create(&output->base,
>> +                                      output->surface, output->surface,
>>                                        gl_renderer->opaque_attribs,
>>                                        &format) < 0) {
>>
>
> I don't see the need for the duplicate arguments here. Both are obviously
> the same value (the xid), it's just that one of the API's declares this as
> EGLNativeWindowType and the other as void*. I think it would be best to
> hide all this ugliness and make output_create take an xid.
>

Keep reading through the diff until you see compositor-x11.c, which has a
comment explaining why it's necessary. Passing an XID directly doesn't help
at all.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150320/dea7080e/attachment-0001.html>