[PATCH weston v2 04/14] tests: Add surface checks

Bryce Harrington bryce at osg.samsung.com
Fri May 15 12:56:11 PDT 2015


On Fri, May 15, 2015 at 04:55:48PM +0300, Pekka Paalanen wrote:
> On Fri, 15 May 2015 01:21:49 -0700
> Bryce Harrington <bryce at osg.samsung.com> wrote:
> 
> > Introduce helper routines for testing surfaces against specific
> > conditions.  These allow tests to validate screen captures as displaying
> > the correct rendering results.
> > 
> > Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> > ---
> >  tests/weston-test-client-helper.c | 116 ++++++++++++++++++++++++++++++++++++++
> >  tests/weston-test-client-helper.h |  15 +++++
> >  2 files changed, 131 insertions(+)
> > 
> > diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c
> > index 080bb62..04b77d5 100644
> > --- a/tests/weston-test-client-helper.c
> > +++ b/tests/weston-test-client-helper.c
> 
> > +bool
> > +check_surfaces_equal(const struct surface *a, const struct surface *b)
> > +{
> > +	int y;
> > +	void *p, *q;
> > +
> > +	if (a == NULL || b == NULL)
> > +		return false;
> > +	if (a->width != b->width || a->height != a->height)
> 
> The latter compares a to a, should be a to b.

Good catch, I actually fix this up in a latter patch.
I was just really tired of squashing patches at this point.  ;-)

Bryce


More information about the wayland-devel mailing list