Patchwork missing the rest of the series (Re: [PATCH wayland 0/3] Restore DTD and use wayland-scanner to validate)

[Pekka Paalanen]

On Tue, 10 Nov 2015 11:35:35 +0000
Damien Lespiau <damien.lespiau at intel.com> wrote:

> On Mon, Nov 09, 2015 at 11:25:17AM +0200, Pekka Paalanen wrote:
> > Hi Damien,
> 
> Hi Pekka,
> 
> > I just noticed that from this patch series of three, only 1/3 shows up
> > in Patchwork as http://patchwork.freedesktop.org/patch/64191/ .
> > The rest are:
> > http://lists.freedesktop.org/archives/wayland-devel/2015-November/025336.html
> > http://lists.freedesktop.org/archives/wayland-devel/2015-November/025337.html
> > 
> > Any idea what's going on?
> > 
> > Looks like annarchy at least does not suffer from a full disk atm.,
> > don't know if it did earlier. I'm not even sure if that is the right
> > machine to look at, but in the past I think annarchy's root disk being
> > full coincided with missing some patches.
> 
> I do have an idea!
> 
> Patchwork hit an assertion and so the patch wasn't processed. The good
> news is that I now receive a mail with the backtrace when it happens, so
> I can have a look and fix the problem. And so I did and it turned out to
> be a tricky one involving series patches sent to a mail thread across
> the boundary where patchwork learned about Series. The minimal-ish test
> case is:
> 
> 
>     + patch                            \
>     +--+ reply 1                        | Before patchwork knew
>        +--+ patch                       | about series
>           +--+ reply 2                 /
>              +--+ cover letter (0/3)   \
>                 +--> patch 1/3          | After patchwork knew
>                 +--> patch 2/3          | about series
>                 +--> patch 3/3         /
> 
> 
> Series support is pretty young, so I'm still ironing out some corner cases.
> 
> I fixed this (with a unit test even!) in:
> 
>   https://github.com/dlespiau/patchwork/commit/4da2a45c6db571af64340c4b8c05315c3460ba56

Oh wow, that was pretty complicated. Thank you!

> I also replayed the two lost paches so you at least have them appear. I
> couldn't replay the replies as I don't receive all the wayland emails
> and we don't archive the real emails but just the mailman-mangled ones.
> 
>   http://patchwork.freedesktop.org/series/593/

Excellent!


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151111/372ec98f/attachment-0001.sig>