[PATCH weston 3/4] compositor-wayland: Properly release input resources when caps change

[Derek Foreman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14/10/15 03:58 AM, Pekka Paalanen wrote:
> On Fri,  9 Oct 2015 11:28:45 -0500 Derek Foreman
> <derekf at osg.samsung.com> wrote:
> 
>> We should use wl_*_release when available instead of destroy, and
>> we should update weston's internal input tracking with
>> weston_seat_releases
>> 
>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com> --- 
>> src/compositor-wayland.c | 15 +++++++++++++-- 1 file changed, 13
>> insertions(+), 2 deletions(-)
>> 
>> diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c 
>> index dbbc1ad..b25f4ea 100644 --- a/src/compositor-wayland.c +++
>> b/src/compositor-wayland.c
> 
>> @@ -1823,6 +1833,7 @@ registry_handle_global(void *data, struct
>> wl_registry *registry, uint32_t name, 
>> &_wl_fullscreen_shell_interface, 1); } else if (strcmp(interface,
>> "wl_seat") == 0) { display_add_seat(b, name, version); +
>> b->seat_version = version; } else if (strcmp(interface,
>> "wl_output") == 0) { wayland_backend_register_output(b, name); }
>> else if (strcmp(interface, "wl_shm") == 0) {
> 
> Inconsiquential nit: you assume all wl_seats will be advertised
> with the same version. I can't imagine a case where they wouldn't,
> but...

Lazily copied the assumption made in toytoolkit a couple of years ago.

If you can explain to me how a reasonable compositor could possibly
advertise seats with different versions on the same connection, I'll
fix both here and there. ;)

> Otherwise looks fine to me.
> 
> 
> Thanks, pq
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJWHmMvAAoJEF5USY5pfxHXeNEH/01pE49/GN2UdKC2r8SCUjsF
UC8S/Xm1SHJDdAdq9a+jOY4ghgncrpD+uhHeIQx7AwMjTjNHYoW9LT5UVtzw3ASv
nT5YudqBG+D9sQUzZNKDjfMuiok3vOTLZu5xPOumbSOeSoLiaG8BF+mJyDcLqwX9
yRXfeu6OPByz1XVb1XDtIE4jiCoGPzxea04p8fdwO+YF/IQDXvhtmkzauvxK7w1Y
ACVOXRaVc9Tt25H/QrLcU1I0uslVPb6NASwJ9+ysl9j15kV66PESbJx4b3svCh/F
mXmDSKQX2ZbBQp6JQPs3Fu7SWU087RzzvE4N/8odhONlTKfAq3vYS4GqQCP6PpI=
=mqIL
-----END PGP SIGNATURE-----